Re: What's cooking in git.git (Jun 2024, #01; Mon, 3)

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 4, 2024, 08:59 UTC
Message-ID: <CAP8UFD08BaDTt86j-X87Q9j9q1bzbB9zODqAOV5d9n2Fy7Jd=A@mail.gmail.com>
In-Reply-To: <xmqqo78h1bdg.fsf@gitster.g>

On Tue, Jun 4, 2024 at 8:19 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> * gt/decorate-unit-test (2024-05-28) 1 commit
>  - t/: migrate helper/test-example-decorate to the unit testing framework
>
>  A test helper that essentially is unit tests on the "decorate"
>  logic has been rewritten using the unit-tests framework.
>
>  Will merge to 'next'?
>  source: <20240528125837.31090-1-shyamthakkar001@gmail.com>

The only nit found in this was about how tests were split. Josh Steadmon recently said that the split is reasonable as it makes things similar to the original code, and I agree with that. So I think it should be good to go.

Show 9 quoted lines

> * gt/t-hash-unit-test (2024-05-29) 2 commits
>  - t/: migrate helper/test-{sha1, sha256} to unit-tests/t-hash
>  - strbuf: introduce strbuf_addstrings() to repeatedly add a string
>
>  A pair of test helpers that essentially are unit tests on hash
>  algorithms have been rewritten using the unit-tests framework.
>
>  Will merge to 'next'?
>  source: <20240529080030.64410-1-shyamthakkar001@gmail.com>

I agree with Patrick that the v5 properly addresses the small nits Patrick found in the v4, and the v5 LGTM.