Re: [PATCH] t5703: replace "grep -a" usage by perl

From: Christian Couder <christian.couder@gmail.com>
Date: May 19, 2020, 14:13 UTC
Message-ID: <CAP8UFD00AAG7hmLEq_LzhcmQ=iHMV27W9+75g9y9JMQSt15j6Q@mail.gmail.com>
In-Reply-To: <20200519113920.GA2051@danh.dev>

On Tue, May 19, 2020 at 1:39 PM Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:

>
> On 2020-05-19 09:13:19+0200, Christian Couder <christian.couder@gmail.com> wrote:
> > On Tue, May 19, 2020 at 3:00 AM Đoàn Trần Công Danh
> > <congdanhqx@gmail.com> wrote:

Show 22 quoted lines

> > >  test_expect_success 'config controls ref-in-want advertisement' '
> >
> > At least you should add the PERL prereq to the test with something like:
> >
> > test_expect_success PERL 'config controls ref-in-want advertisement' '
>
> Well, that's is not t/README says:
>
>  - PERL
>
>    Git wasn't compiled with NO_PERL=YesPlease.
>
>    Even without the PERL prerequisite, tests can assume there is a
>    usable perl interpreter at $PERL_PATH, though it need not be
>    particularly modern.
>
> And, there're a lot of tests using perl without PERL prereq:
>
>         $ git grep -l '[        ]perl ' 't/t????-*.sh' | wc -l
>         55
>         $ git grep -l PERL 't/t????-*.sh' | wc -l
>         35

Ok, sorry about the noise then.