Re: git config error message
- From
Ben Walton <bdwalton@gmail.com>
- Date
- Oct 27, 2012, 08:45 UTC
- Message-ID
- <CAP30j15pUwX9sD3FXAfroxFK9paHmb1eAg+M5YAHT4aB22DBEw@mail.gmail.com>
- In-Reply-To
- <CAB9Jk9CONVSZvBUgnZHiniwPHHvcap8Wyjyw-sCHaSokDoNRWA@mail.gmail.com>
On Sat, Oct 27, 2012 at 9:32 AM, Angelo Borsotti <angelo.borsotti@gmail.com> wrote:
Hi Angelo,
> I wrote "value", but I meant "name". The first example I made contains > a name with a nonexistent section, the second a name with a > nonexistent key.
This still wouldn't be an error condition though, especially in terms of how "git config" should treat it. It should be up to the consumer of the information to display, or not, any error or diagnostics that don't result from either a bad request (your first case) or a malformed configuration file. This fits with the callback nature of how the config file is parsed by builtin tools. The exit code from "git config" with a missing key is enough for the consumer to make this decision.
This is just my take on it, but I think the current approach makes sense.
Thanks -Ben
-- --------------------------------------------------------------------------------------------------------------------------- Take the risk of thinking for yourself. Much more happiness, truth, beauty and wisdom will come to you that way. -Christopher Hitchens ---------------------------------------------------------------------------------------------------------------------------