git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] git-prompt.sh: refactor colored prompt code

From
Eduardo R. D'Avila <erdavila@gmail.com>
Date
Jun 25, 2013, 01:21 UTC
Message-ID
<CAOz-D1Lfh5tnjMriQNQtNYeMUHb=jLbjzxt0=Nru8gPYwVk79A@mail.gmail.com>
In-Reply-To
<20130623145157.GN20052@goldbirke>
2013/6/23 SZEDER Gábor <szeder@ira.uka.de>:
Show 8 quoted lines
> I'm wary of relying on tput's availability.  It's part of ncurses,
> which is an essential package in many (most? all?) linux distros, but
> I don't know how it is with other supported platforms.  So I think
> we'd have to stick to the hard-coded escape sequences as a fallback
> anyway. (...)
>
> However, I don't know much about the caveats of terminals, so I can't
> judge the benefits of using tput instead of the escape sequences.
I'm exactly in the same situation...
> considering the additional delay that would be caused by fork()ing
> four subshells and fork()+exec()ing four external commands on Windows.
Well... That would be only once, during script loading.

Given the concerns raised by Gábor (edited and quoted above) and that there is no known issue (afaik) with the current implementation, I'm tending to revert to the escape sequences.

Previous: SZEDER GáborNext: Eduardo R. D'Avila
Message 11 of 15 in “git-prompt: cleaning and improvement”
  1. 0/4 git-prompt: cleaning and improvementEduardo R. D'Avila, Jun 21, 2013
  2. 1/4 t9903: add tests for git-prompt pcmodeEduardo R. D'Avila, Jun 21, 2013
  3. SZEDER GáborJun 22, 2013
  4. Eduardo D'AvilaJun 22, 2013
  5. Junio C HamanoJun 23, 2013
  6. SZEDER GáborJun 24, 2013
  7. 2/4 git-prompt.sh: refactor colored prompt codeEduardo R. D'Avila, Jun 21, 2013
  8. Øystein WalleJun 22, 2013
  9. Eduardo D'AvilaJun 22, 2013
  10. SZEDER GáborJun 23, 2013
  11. Eduardo R. D'AvilaJun 25, 2013
  12. 3/4 git-prompt.sh: do not print duplicate clean color codeEduardo R. D'Avila, Jun 21, 2013
  13. SZEDER GáborJun 22, 2013
  14. 4/4 git-prompt.sh: add missing information in commentsEduardo R. D'Avila, Jun 21, 2013
  15. SZEDER GáborJun 22, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.