Re: [RFC PATCH] Option to allow cherry-pick to skip empty commits
- From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
- Date
- Jan 23, 2017, 20:05 UTC
- Message-ID
- <CAOxFTcxRjWS-=wyGBVOtg-tfCHrqqAr9rVOcvkyxXwJHonN_Tg@mail.gmail.com>
- In-Reply-To
- <xmqqd1fdtzgv.fsf@gitster.mtv.corp.google.com>
On Mon, Jan 23, 2017 at 7:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes: > >> By the way, I noticed going over the code that the -allow options are >> not stored, so that in case of interruption they will be reset, is >> this intentional or a bug? > > I do not know offhand, but given the history of the two commands, I > would guess it was a bug simply overlooked when people bolted "a > series of commits" mode onto these commands that originally worked > only on a single commit.
It seems like a bug to me. I'll prepare a new series that also fixes this. I still don't see how to force a complete reread of the index after running a git reset (which I need for the --skip command), but maybe I'll add a WIP of what I have for --skip so far and people can comment on that.
-- Giuseppe "Oblomov" Bilotta