git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] am: format is in $patch_format, not parse_patch

From
Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date
Aug 29, 2011, 16:46 UTC
Message-ID
<CAOxFTcwcBgCNpwNNdsQXwE92w6948cfjwMTum03D+SJ0Rq-Yuw@mail.gmail.com>
In-Reply-To
<7vaaas6vtt.fsf@alter.siamese.dyndns.org>
On Mon, Aug 29, 2011 at 6:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>> The error message given when the patch format was not recognized was
>> wrong, since the variable checked was $parse_patch rather than
>> $patch_format. Fix by checking the non-emptyness of the correct
>> variable.
>
> Thanks for a fix to a problem that is from more than two years ago ;-)

You're welcome. I'm actually surprised that wasn't something _I_ did by mistake ;-)

That part of the code isn't being stressed too much. I've just found another issue. Patch coming, plus another enhancement.

-- 
Giuseppe "Oblomov" Bilotta
Previous: Junio C Hamano
Message 3 of 3 in “am: format is in $patch_format, not parse_patch”
  1. am: format is in $patch_format, not parse_patchGiuseppe Bilotta, Aug 29, 2011
  2. Junio C HamanoAug 29, 2011
  3. Giuseppe BilottaAug 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.