Re: [PATCH] http.c: Use curl_multi_fdset to select on curl fds instead of just sleeping
- From
Mika Fischer <mika.fischer@zoopnet.de>
- Date
- Nov 2, 2011, 08:21 UTC
- Message-ID
- <CAOs=hR+u_MrHK4iNFZj4pLVhZ6-_75YpqN7tqWnSjh+di8Lzxw@mail.gmail.com>
- In-Reply-To
- <CAOs=hR+YuF+HP0n0132Ktm3RdeWsnVp0Bgt89LNn+VyT6W0mcw@mail.gmail.com>
Show 9 quoted lines
>> Calling select() with max_fd+1 (== 0) will then not be appreciated by all >> implementations of select() so that case should probably also be covered by >> the 50ms sleep approach... > > Actually, the 50ms sleep was also implemented using select(0, ...) > before the patch. I tried to keep the previous behavior when curl does > not give us any information. > I assumed that the select(0, ...) was some portable way to sleep with > microsecond granularity.
Upon a bit of research, it seems that select(0, ...) is indeed quite commonly used. So I'd just keep it as it was unless you know of a problem it causes.
Since I'm new here, I don't really know what the next steps are for the patch, should I just wait? Or send it directly to someone?
Best, Mika