git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: fix error when resizing gitk

From
HSHalil SEN <halilsen@gmail.com>
Date
Feb 23, 2022, 15:03 UTC
Message-ID
<CAOeUTuuyftWB=PaA9HPDnyxsb40R3Z6GD65TB92jEW+38goqRg@mail.gmail.com>
In-Reply-To
<20211125125720.231039-1-ms@kilabit.info>
Hello Shulhan,

I just stumbled upon your patch while looking for the patch that I sent at the beginning of this week for the exact same issue. It turns out you sent your patch two months ago. I should have checked before debugging :face_palm:

If you would like to check it out, here is my patch in [1].

I see that you have fixed resizeclistpanes but exact same issue is present on resizecdetpanes as well.

I am not sure if the conditional logic is necessary because we are sure that `sash#` includes x, y positions in ttk mode but it includes only the x position if not ttk. Also setting the y coord to 0 might have unintended consequences.

[1] https://lore.kernel.org/git/0b5b8fb591e434a2a24b1f58d1ce3fc7da48a28e.1645386457.git.gitgitgadget@gmail.com/
Signed-off-by: Halil Sen <halil.sen@gmail.com>
Previous: ShulhanNext: Shulhan
Message 2 of 3 in “gitk: fix error when resizing gitk”
  1. gitk: fix error when resizing gitkShulhan, Nov 25, 2021
  2. Halil SENFeb 23, 2022
  3. ShulhanFeb 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.