Re: [PATCH] checkout: refactor of --progress option

From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date: Oct 31, 2015, 17:10 UTC
Message-ID: <CAOc6etasvk6f0XhJumwXtYiC7h_ufQUAyN1BktQ=qdd4_f0hSQ@mail.gmail.com>
In-Reply-To: <1446310669-9790-1-git-send-email-eantoranz@gmail.com>

On Sat, Oct 31, 2015 at 10:57 AM, Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

Show 10 quoted lines

> +       /*
> +        * Final processing of show_progress
> +        * Any of these 3 conditions will make progress output be skipped:
> +        * - selected --quiet
> +        * - selected --no-progress
> +        * - didn't select --progress and not working on a terminal
> +        */
> +       opts.show_progress = !opts.quiet && opts.show_progress &&
> +                            (opts.show_progress > 0 || isatty(2));
> +

I did a very small adjustment there from what I had sent yesterday.

It was (opts.show_progress >= 0 || isatty(2))

It was unnecessary to include the case of a 0 because it was discarded by the second item on the outer short-circuited if: opts_show_progress.

Let me know of your feedback and thanks.