Re: [RFC] sequencer: allow metadata to be saved if using cherry-pick --no-commit
- From
Edmundo Carmona Antoranz <eantoranz@gmail.com>
- Date
- Oct 21, 2020, 06:31 UTC
- Message-ID
- <CAOc6eta3xMMH_m3+Apiy7uY94MECLRGiV2y=kNmCzwh0MS=36g@mail.gmail.com>
- In-Reply-To
- <20201021062430.2029566-1-eantoranz@gmail.com>
On Wed, Oct 21, 2020 at 12:24 AM Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:
Show 5 quoted lines
> > > With this patch, we allow sequencer to save the metadata from the original > cherry-pick operation so that 'git cherry-pick --continue' can be called. >
I would expect 'git cherry-pick --no-commit' to save the metadata from the revision cherry-picked if the operation is successful so to allow running 'git cherry-pick --continue' afterwards, however that's not the case. I was wondering if this is done on purpose. The patch in the RFC is not in any way my final proposal (or even a real proposal) but just a little first step so that I can gather information so that I can adjust the code accordingly from all the feedback... _if_ an adjustment is needed, of course. I don't know how --no-commit would have to play out if multiple revisions are asked to be processed by sequencer, for example.