git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] blame: report correct number of lines in progress when using ranges

From
Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date
Apr 6, 2022, 17:46 UTC
Message-ID
<CAOc6etZkOTs-XonAxEWPt8SepUALg8yprtKA_6=H1AbjOtmwCw@mail.gmail.com>
In-Reply-To
<xmqq7d82yx06.fsf@gitster.g>
On Wed, Apr 6, 2022 at 6:52 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
>
>
> I do not think that is something we want to test, or distract the
> developers by forcing them to update the skipping hardcoded in the
> test.
>
> Is it easy to grab the last progress message from the output?  What
> we care, and have cared in the past, is that we expect that the 100%
> is paired with the number of lines in the ranges, and the progress
> actually ends at 100% (we had different bugs that did not bring the
> meter to 100% at the end), so checking that end result would be what
> matters most, e.g.
>
>     tr '\015' '\012' output | tail -n 1
>
> or something?
>

Let me send the next version of the patch that will hopefully get the best of all the ideas we have been throwing around.

Previous: Junio C HamanoNext: Edmundo Carmona Antoranz
Message 4 of 5 in “blame: report correct number of lines in progress when using ranges”
  1. blame: report correct number of lines in progress when using rangesEdmundo Carmona Antoranz, Apr 5, 2022
  2. Ævar Arnfjörð BjarmasonApr 6, 2022
  3. Junio C HamanoApr 6, 2022
  4. Edmundo Carmona AntoranzApr 6, 2022
  5. Edmundo Carmona AntoranzApr 6, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.