Re: [PATCH v3] blame: report correct number of lines in progress when using ranges
- From
Edmundo Carmona Antoranz <eantoranz@gmail.com>
- Date
- Apr 6, 2022, 17:46 UTC
- Message-ID
- <CAOc6etZkOTs-XonAxEWPt8SepUALg8yprtKA_6=H1AbjOtmwCw@mail.gmail.com>
- In-Reply-To
- <xmqq7d82yx06.fsf@gitster.g>
On Wed, Apr 6, 2022 at 6:52 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> > > I do not think that is something we want to test, or distract the > developers by forcing them to update the skipping hardcoded in the > test. > > Is it easy to grab the last progress message from the output? What > we care, and have cared in the past, is that we expect that the 100% > is paired with the number of lines in the ranges, and the progress > actually ends at 100% (we had different bugs that did not bring the > meter to 100% at the end), so checking that end result would be what > matters most, e.g. > > tr '\015' '\012' output | tail -n 1 > > or something? >
Let me send the next version of the patch that will hopefully get the best of all the ideas we have been throwing around.