Does it make sense to show tips on blame?
- From
Edmundo Carmona Antoranz <eantoranz@gmail.com>
- Date
- Jan 21, 2017, 05:23 UTC
- Message-ID
- <CAOc6etZ9QeJAf1CKh9Eraigwy45yR6eO-7Th+bZRnTa71BoPew@mail.gmail.com>
Hi!
I'm having fun with difflame. I added support for an option called 'tips' which would display 1-line summary of a block of added lines that belong to the same revision, in order to provide context while reading difflame output without having to run an additional git show command.
Output is like this (from README.txt, taken from difflame on git itself, sorry if it's too wide):
diff --git a/fast-import.c b/fast-import.c index f561ba833..64fe602f0 100644 --- a/fast-import.c +++ b/fast-import.c @@ -2218,13 +2218,17 @@ static uintmax_t do_change_note_fanout( 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2218) char *fullpath, unsigned int fullpath_len, 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2219) unsigned char fanout) 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2220) { -02d0457eb4 (Junio C Hamano 2017-01-10 15:24:26 -0800 2221) struct tree_content *t = root->tree; 405d7f4af fast-import: properly fanout notes when tree is imported +405d7f4af6 (Mike Hommey 2016-12-21 06:04:48 +0900 2221) struct tree_content *t; 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2222) struct tree_entry *e, leaf; 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2223) unsigned int i, tmp_hex_sha1_len, tmp_fullpath_len; 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2224) uintmax_t num_notes = 0; 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2225) unsigned char sha1[20]; 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2226) char realpath[60]; 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2227) 405d7f4af fast-import: properly fanout notes when tree is imported +405d7f4af6 (Mike Hommey 2016-12-21 06:04:48 +0900 2228) if (!root->tree) +405d7f4af6 (Mike Hommey 2016-12-21 06:04:48 +0900 2229) load_tree(root); +405d7f4af6 (Mike Hommey 2016-12-21 06:04:48 +0900 2230) t = root->tree; +405d7f4af6 (Mike Hommey 2016-12-21 06:04:48 +0900 2231) 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2232) for (i = 0; t && i < t->entry_count; i++) { 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2233) e = t->entries[i]; 2a113aee9b (Johan Herland 2009-12-07 12:27:24 +0100 2234) tmp_hex_sha1_len = hex_sha1_len + e->name->str_len; The tip that was used for revision 405d7f4af on both "blocks" of added lines can be seen. The question is if you think it makes sense to add this option to git-blame itself. Something like: git blame --tips README.txt Thanks in advance