Re: [PATCH v3] checkout: add --progress option

From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date: Nov 1, 2015, 17:43 UTC
Message-ID: <CAOc6etZ7Vcd-Gq6bV6VuzJQY2om7k0gWfGYsSmQ8xYtGvOWBxQ@mail.gmail.com>
In-Reply-To: <1446398545-8245-1-git-send-email-eantoranz@gmail.com>

On Sun, Nov 1, 2015 at 11:22 AM, Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

Show 19 quoted lines

> +       /*
> +        * Final processing of show_progress
> +        * - User selected --progress: show progress
> +        * - user selected --no-progress: skip progress
> +        * - User didn't specify:
> +        *     (check rules in order till finding the first matching one)
> +        *     - user selected --quiet: skip progress
> +        *     - stderr is connected to a terminal: show progress
> +        *     - fallback: skip progress
> +        */
> +       if (opts.show_progress < 0) {
> +               /* user selected --progress or didn't specify */
> +               if (opts.quiet) {
> +                       opts.show_progress = 0;
> +               } else {
> +                       opts.show_progress = isatty(2);
> +               }
> +       }
> +

/* user selected --progress or didn't specify */ This comment is not correct. Disregard this patch.