git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] builtin/merge.c - cleanup of code in for-cycle that tests strategies

From
Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date
Jul 7, 2019, 03:15 UTC
Message-ID
<CAOc6etYGA_rHhrDgMbf4x_GxdWwgWy7W2Kqvv6PsMMHFP0U_vA@mail.gmail.com>
In-Reply-To
<20190707000052.26057-1-eantoranz@gmail.com>

On Sat, Jul 6, 2019 at 6:00 PM Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

Show 8 quoted lines
> @@ -1645,6 +1631,7 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
>          * auto resolved the merge cleanly.
>          */
>         if (automerge_was_ok) {
> +               write_tree_trivial(&result_tree);
>                 ret = finish_automerge(head_commit, head_subsumed,
>                                        common, remoteheads,
>                                        &result_tree, wt_strategy);

I realized later that the call to write_tree_trivial could be included in finish_automerge. Will include this change on v2 of the patch (if there's a v2, depending on feedback).

Previous: Edmundo Carmona AntoranzNext: Junio C Hamano
Message 2 of 4 in “builtin/merge.c - cleanup of code in for-cycle that tests strategies”
  1. builtin/merge.c - cleanup of code in for-cycle that tests strategiesEdmundo Carmona Antoranz, Jul 7, 2019
  2. Edmundo Carmona AntoranzJul 7, 2019
  3. Junio C HamanoJul 8, 2019
  4. Edmundo Carmona AntoranzJul 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.