git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: fsmonitor deadlock / macOS CI hangs

From
Koji Nakamaru <koji.nakamaru@gree.net>
Date
Oct 2, 2024, 09:51 UTC
Message-ID
<CAOTNsDy-0TMQMP-7kdLkvdCmXLhHbPJYewSrRZu9m3B=TgdFSA@mail.gmail.com>
In-Reply-To
<20241002062539.GA2863841@coredump.intra.peff.net>
On Wed, Oct 2, 2024 at 3:25 PM Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
> The solution then is to avoid letting any client threads run (or at
> least create cookies) until we know we're listening for fs events.
> Naively I would say we should just have the fs event thread signal us
> that it's ready before we spawn any of the client threads. But it looks
> like we explicitly start those threads first in fsmonitor_run_daemon_1():

I submitted a fix that followed this approach as it is easy to understand and should not have any unexpected behaviour. Could you please check it?

https://lore.kernel.org/git/pull.1804.git.1727862424713.gitgitgadget@gmail.com/
Koji Nakamaru
Previous: Jeff King
Message 4 of 4 in “fsmonitor deadlock / macOS CI hangs”
  1. Jeff KingSep 30, 2024
  2. Koji NakamaruOct 2, 2024
  3. Jeff KingOct 2, 2024
  4. Koji NakamaruOct 2, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.