git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] doc: merge: fix mention of `ORIG_HEAD`

From
MSMinnie Shi <minnie.shi@gmail.com>
Date
May 20, 2023, 09:41 UTC
Message-ID
<CAOQx3Ab8BoWpZJWMQsyutNi5GZpck+qwMhKbhM5aeOGHqbRESg@mail.gmail.com>
In-Reply-To
<CAOQx3Aa9_cW-s6YoeYLac0j8VuhJ8cvEdGieS-+K-gD7D7TBRQ@mail.gmail.com>
Okay, i read one more time, i think it should be read as

Before the operation, -`ORIG_HEAD` is set to the tip of the "current" branch (`G`)

instead of Before the operation, -`ORIG_HEAD` is set to the tip of the "current" branch (`C`)

On Sat, May 20, 2023 at 11:25 AM Minnie Shi <minnie.shi@gmail.com> wrote:
Show 52 quoted lines
>
> The document says the “current” branch is master , which means the
> HEAD is (G), which does not matter, it is not what I am challenging.
>
> What I am challenging is that it continues the context and says:
>
> Before the operation,
> -`ORIG_HEAD` is set to the tip of the "current" branch (`C`).
>
> that is not true, current branch is master, and it is (G), Maybe it
> should be changed to "topic branch", so it reads like this:
>
> Before the operation,
> -`ORIG_HEAD` is set to the tip of the ”topic” branch (`C`).
>
>
> Min
>
> On Sat, May 20, 2023 at 10:45 AM Kristoffer Haugsbakk
> <code@khaugsbakk.name> wrote:
> >
> > `ORIG_HEAD` before the attempted merge points at the commit that you are
> > on (the tip of `master`), not the tip of the branch that you are trying
> > to merge in.
> >
> > Reported-by: Minnie Shi <minnie.shi@gmail.com>
> > Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> > ---
> >  Documentation/git-merge.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/git-merge.txt b/Documentation/git-merge.txt
> > index 0aeff572a59..9019b6a1e50 100644
> > --- a/Documentation/git-merge.txt
> > +++ b/Documentation/git-merge.txt
> > @@ -38,7 +38,7 @@ Then "`git merge topic`" will replay the changes made on the
> >  its current commit (`C`) on top of `master`, and record the result
> >  in a new commit along with the names of the two parent commits and
> >  a log message from the user describing the changes. Before the operation,
> > -`ORIG_HEAD` is set to the tip of the current branch (`C`).
> > +`ORIG_HEAD` is set to the tip of the current branch (`G`).
> >
> >  ------------
> >           A---B---C topic
> > --
> > 2.41.0.rc1
> >
>
>
> --
> Kind regards
> Min
-- 
Kind regards
Min
Previous: Minnie ShiNext: Junio C Hamano
Message 4 of 9 in “I think there is error in merge documents - current branch”
  1. Minnie ShiMay 20, 2023
  2. doc: merge: fix mention of `ORIG_HEAD`Kristoffer Haugsbakk, May 20, 2023
  3. Minnie ShiMay 20, 2023
  4. Minnie ShiMay 20, 2023
  5. Junio C HamanoMay 20, 2023
  6. Kristoffer HaugsbakkMay 21, 2023
  7. Sergey OrganovMay 21, 2023
  8. Minnie ShiMay 21, 2023
  9. Minnie ShiMay 21, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.