Re: [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+

From: Alejandro R. Sedeño <asedeno@mit.edu>
Date: Oct 5, 2022, 22:22 UTC
Message-ID: <CAOO-Oz1gQJJDiweWjeJAKq1ooVDwH629sXUAGPRd=efxJHK6yA@mail.gmail.com>
In-Reply-To: <xmqqilkynd91.fsf@gitster.g>

Sorry for the subject line change; I had hoped that --in-reply-to would get it threaded properly and wanted to trim it down a bit.

-> "[PATCH] git-compat-util.h: GCC deprecated message arg only in GCC 4.5+"

-Alejandro

On Wed, Oct 5, 2022 at 5:59 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 25 quoted lines

>
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > On 2022-10-03 at 21:23:18, Aleajndro R Sedeño wrote:
> >> From: Alejandro R. Sedeño <asedeno@mit.edu>
> >>
> >> Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
> >> Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
> >
> > It might be helpful to explain what system you're targeting when you see
> > this.  CentOS 7 has GCC 4.8, and I'm not aware of any systems with an
> > older compiler receiving publicly available updates still.  We've fairly
> > recently only been testing and targeting GCC 4.8 for that reason.
>
> I do agree with you that an update to give "why" in the proposed log
> message would be very welcome, e.g. "Even though such an ancient
> compiler may not matter much in real life, a workaround is simple
> enough." or something along that line.
>
> As to the change in the patch, I think it is good.
>
> Thanks, all.  Expecting an updated version which hopefully would
> become the final version ;-)
>
>