git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: fix auth parameter handling on SVN 1.9.0+

From
TVThierry Vignaud <thierry.vignaud@gmail.com>
Date
Jan 16, 2016, 14:00 UTC
Message-ID
<CAONrEtbEVwP8VxdYgar5oDtK4q94f5L_nAtFokSo8vVnp0ixog@mail.gmail.com>
In-Reply-To
<20160116101719.GA21147@dcvr.yhbt.net>
On 16 January 2016 at 11:17, Eric Wong <normalperson@yhbt.net> wrote:
Show 33 quoted lines
> For users with "store-passwords = no" set in the "[auth]" section of
> their ~/.subversion/config, SVN 1.9.0+ would fail with the
> following message when attempting to call svn_auth_set_parameter:
>
>   Value is not a string (or undef) at Git/SVN/Ra.pm
>
> Ironically, this breakage was caused by r1553823 in subversion:
>
>   "Make svn_auth_set_parameter() usable from Perl bindings."
>
> Since 2007 (602015e0e6ec), git-svn has used a workaround to make
> svn_auth_set_parameter usable internally.  However this workaround
> breaks under SVN 1.9+, which deals properly with the type mapping
> and fails to recognize our workaround.
>
> For pre-1.9.0 SVN, we continue to use the existing workaround for
> the lack of proper type mapping in the bindings.
>
> Tested under subversion 1.6.17 and 1.9.3.
>
> I've also verified r1553823 was not backported to SVN 1.8.x:
>
>   BRANCH=http://svn.apache.org/repos/asf/subversion/branches/1.8.x
>   svn log -v $BRANCH/subversion/bindings/swig/core.i
>
> ref: https://bugs.debian.org/797705
> Cc: 797705@bugs.debian.org
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> ---
>  Thanks to the reporter (Bcc:-ed to protect their privacy) who
>  notified Dair and I of this bug.
>
>  Junio: this should also head to maint, thanks.

Thanks, I confirm it fixed the issue. You can add the following if you want:

Reported-by: Thierry Vignaud <thierry.vignaud@gmail.com>
Tested-by: Thierry Vignaud <thierry.vignaud@gmail.com>
Previous: Eric Wong
Message 2 of 2 in “git-svn: fix auth parameter handling on SVN 1.9.0+”
  1. git-svn: fix auth parameter handling on SVN 1.9.0+Eric Wong, Jan 16, 2016
  2. Thierry VignaudJan 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.