Re: [PATCH v2 1/7] refs: drop unnecessary header includes
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jan 19, 2026, 08:53 UTC
- Message-ID
- <CAOLa=ZTuD=bcO2pin6CWYFrc9Lwnq5JWy99cUGt8bOYkGh8vHw@mail.gmail.com>
- In-Reply-To
- <aWzM+qePiaRWz5/f@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 21 quoted lines
> On Fri, Jan 16, 2026 at 10:27:06PM +0100, Karthik Nayak wrote: >> The 'sigchain.h' header isn't being used and can be removed. >> >> Similarly, 'run-command.h' serves no direct purpose here. While it gets pulled in transitively through 'hook.h', we can still drop the explicit include for clarity. > > The need for these #includes went away fairly recently, I think in > 26238496a7 (hook: provide stdin via callback, 2025-12-26) and > 7a7717427e (reference-transaction: use hook API instead of > run-command, 2025-12-26), which were merged in f406b89552 (Merge > branch 'ar/run-command-hook', 2026-01-06). Unfortunately, that topic > had some regressions and therefore was reverted in a3d1f391d3 (Revert > "Merge branch 'ar/run-command-hook'", 2026-01-15), and as a result > merging this topic into seen resulted in a merge commit 180b93f7ba > (Merge branch 'kn/ref-batch-output-error-reporting-fix' into jch, > 2026-01-16) that can't be built. > > I think this patch should be dropped from this series, and these > #includes should be removed in that other topic. > > https://public-inbox.org/git/20251226122334.16687-1-adrian.ratiu@collabora.com/T/#u >
Sounds good, thanks for letting me know. I'll drop it from the next version!