Re: [GSoC PATCH 0/2] Update MyFirstObjectWalk with struct repository and meson

From: Karthik Nayak <karthik.188@gmail.com>
Date: May 29, 2025, 20:06 UTC
Message-ID: <CAOLa=ZTt4eFLZ3kak4g_kW=UH0YGbUMFgB617wvUzTtQ4me6-Q@mail.gmail.com>
In-Reply-To: <20250529192036.75408-1-lucasseikioshiro@gmail.com>

Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:

Show 12 quoted lines

> Hi!
>
> I was studying for GSoC using this documentation, but I found out that two
> things were outdated:
>
> 1. The lack of using the `struct repository *repo*` parameter in some functions;
> 2. There were a instruction for adding the new command to the Makefile, but
> there are no mentions to Meson.
>
> This patchset updates this documentation file, and hopefully will help future
> new contributors.
>

Thanks for this. These documents are often missed by regular contributors since they don't refer to them as much as newcomers. So good to see that it is being updated.

I've left some small comments, but overall this looks good.

Show 9 quoted lines

> Lucas Seiki Oshiro (2):
>   MyFirstContribution: use struct repository in examples
>   MyFirstContribution: add walken.c to meson.build
>
>  Documentation/MyFirstObjectWalk.adoc | 27 +++++++++++++++++----------
>  1 file changed, 17 insertions(+), 10 deletions(-)
>
> --
> 2.39.5 (Apple Git-154)