git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/8] branch: roll show_detached HEAD into regular ref_list

From
Karthik Nayak <karthik.188@gmail.com>
Date
Aug 19, 2015, 15:57 UTC
Message-ID
<CAOLa=ZTsgG4_hVV7+gEBt8AXWkYWi6AoB3Kj9wTYJ4KK60vE_g@mail.gmail.com>
In-Reply-To
<vpqpp2j2toq.fsf@anie.imag.fr>

On Wed, Aug 19, 2015 at 8:48 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 13 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +     /*
>> +      * First we obtain all regular branch refs and if the HEAD is
>> +      * detached then we insert that ref to the end of the ref_fist
>> +      * so that it can be printed first.
>> +      */
>
> Nit: the end of the sentence reads funny (why put at the end "so that it
> can be printed first.").
>
> Perhaps "... so that it can be printed and removed first.".
>
Will change, thanks :)
-- 
Regards,
Karthik Nayak
Previous: Matthieu MoyNext: Karthik Nayak
Message 6 of 13 in “port brnach.c to use ref-filter APIs”
  1. 0/8 port brnach.c to use ref-filter APIsKarthik Nayak, Aug 18, 2015
  2. 1/8 branch: refactor width computationKarthik Nayak, Aug 18, 2015
  3. 2/8 branch: bump get_head_description() to the topKarthik Nayak, Aug 18, 2015
  4. 3/8 branch: roll show_detached HEAD into regular ref_listKarthik Nayak, Aug 18, 2015
  5. Matthieu MoyAug 19, 2015
  6. Karthik NayakAug 19, 2015
  7. 4/8 branch: move 'current' check down to the presentation layerKarthik Nayak, Aug 18, 2015
  8. 5/8 branch: drop non-commit error reportingKarthik Nayak, Aug 18, 2015
  9. Matthieu MoyAug 19, 2015
  10. Karthik NayakAug 19, 2015
  11. 6/8 branch.c: use 'ref-filter' data structuresKarthik Nayak, Aug 18, 2015
  12. 7/8 branch.c: use 'ref-filter' APIsKarthik Nayak, Aug 18, 2015
  13. 8/8 branch: add '--points-at' optionKarthik Nayak, Aug 18, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.