Re: Bug in 2.48 with `git refs migrate`

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jan 17, 2025, 06:17 UTC
Message-ID: <CAOLa=ZTqv4owoj5qFjn9XqKahsmBhY-CynQJstWcP=OBChRn5g@mail.gmail.com>
In-Reply-To: <xmqqmsfqnw4s.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
>> On 2025-01-15 at 11:54:51, Karthik Nayak wrote:
>>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>>> I'm attaching a patch below which should fixes the issue for me and also
>>> adding a test to test against the same. I'd be grateful if you could
>>> also test the patch against the repositoryies you mention.
>>
>> I can confirm that the patch did indeed fix the problem.  I was able to
>> convert both repositories successfully (and very quickly, no less), and
>> they both work fine (I did normal development activity with them) with
>> an unmodified Git 2.48 after the migration process.
>>
>> Thanks again for the quick fix.
>
> Thanks, both.  Let's merge it down to 'next' and then to 'master',
> then.

I was going to send some additional commits around the patch as a v2, but I think they can come in as follow ups. This would ensure that the fix is already in place and we can discuss over the other commits slowly.

Thanks