git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] loose: don't rely on repository global state

From
Karthik Nayak <karthik.188@gmail.com>
Date
Oct 9, 2024, 19:41 UTC
Message-ID
<CAOLa=ZThTs=EzFEAHM+aLJ5Eq_E-RPfGrKiceDADsBGJQE859w@mail.gmail.com>
In-Reply-To
<xmqqcyk9rtwv.fsf@gitster.g>
On Wed, Oct 9, 2024 at 8:52 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
>
> Karthik Nayak <karthik.188@gmail.com> writes:
>
> >                       strbuf_addf(&buf, "%s %s\n", oid_to_hex(&kh_key(map, iter)),
> > oid_to_hex(kh_value(map, iter)));
>
> The line seems corrupt.  Joining them with one SP in between makes
> the patch cleanly apply.

Indeed. I used `format-patch` and `send-email` right after, I don't remember messing with it, but perhaps I did. Thanks for fixing it up and checking.

Previous: Junio C HamanoNext: Patrick Steinhardt
Message 3 of 4 in “loose: don't rely on repository global state”
  1. loose: don't rely on repository global stateKarthik Nayak, Oct 9, 2024
  2. Junio C HamanoOct 9, 2024
  3. Karthik NayakOct 9, 2024
  4. Patrick SteinhardtOct 10, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.