git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 6/6] refs: add GIT_REFERENCE_BACKEND to specify reference backend

From
Karthik Nayak <karthik.188@gmail.com>
Date
Feb 20, 2026, 09:15 UTC
Message-ID
<CAOLa=ZTKa6uvpPG7S+kkLpzey36J9zBjzV2sneFxcmzMmPyzHw@mail.gmail.com>
In-Reply-To
<aZct2M3sbQSduK2q@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
[snip]
Show 17 quoted lines
>> -test_expect_success 'URI is invalid' '
>> +# Verify that the expected files are present in the gitdir and the refsdir.
>> +# Usage: verify_files_exist <gitdir> <refdir>
>> +#   <gitdir> is the path for the gitdir.
>> +#   <refdir> is the path for the refdir.
>> +verify_files_exist() {
>> +	gitdir=$1 &&
>> +	refdir=$2 &&
>> +
>> +	# verify that the stubs were added to the $GITDIR.
>> +	cat $gitdir/refs/heads >actual &&
>> +	echo "repository uses alternate refs storage" >expect &&
>> +	test_cmp expect actual &&
>
> Tiny nit, not worth addressing on its own: we could simply `test_cmp
> expect "$gitdir/refs/heads", without the need to copy that file first.
>

Indeed. I'll make this change locally, but hold off on re-rolling for now.

Show 9 quoted lines
>> +	cat $gitdir/HEAD >actual &&
>> +	echo "ref: refs/heads/.invalid" >expect &&
>> +	test_cmp expect actual
>
> Same here, no need to copy the file around.
>
> Other than that I'm happy with this patch series now, thanks!
>
> Patrick

I'm also quite happy with how its turned out. Thanks for the continuous reviews.

Karthik
Previous: Patrick Steinhardt
Message 15 of 15 in “refs: allow setting the reference directory”
  1. 0/6 refs: allow setting the reference directoryKarthik Nayak, Feb 19, 2026
  2. 1/6 setup: don't modify repo in `create_reference_database()`Karthik Nayak, Feb 19, 2026
  3. 2/6 refs: extract out `refs_create_refdir_stubs()`Karthik Nayak, Feb 19, 2026
  4. 3/6 refs: move out stub modification to generic layerKarthik Nayak, Feb 19, 2026
  5. Toon ClaesFeb 20, 2026
  6. 4/6 refs: receive and use the reference storage payloadKarthik Nayak, Feb 19, 2026
  7. Toon ClaesFeb 20, 2026
  8. Karthik NayakFeb 22, 2026
  9. 5/6 refs: allow reference location in refstorage configKarthik Nayak, Feb 19, 2026
  10. Toon ClaesFeb 20, 2026
  11. Junio C HamanoFeb 20, 2026
  12. Karthik NayakFeb 22, 2026
  13. 6/6 refs: add GIT_REFERENCE_BACKEND to specify reference backendKarthik Nayak, Feb 19, 2026
  14. Patrick SteinhardtFeb 19, 2026
  15. Karthik NayakFeb 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.