Re: [PATCH v7 6/6] refs: add GIT_REFERENCE_BACKEND to specify reference backend
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Feb 20, 2026, 09:15 UTC
- Message-ID
- <CAOLa=ZTKa6uvpPG7S+kkLpzey36J9zBjzV2sneFxcmzMmPyzHw@mail.gmail.com>
- In-Reply-To
- <aZct2M3sbQSduK2q@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
[snip]
Show 17 quoted lines
>> -test_expect_success 'URI is invalid' '
>> +# Verify that the expected files are present in the gitdir and the refsdir.
>> +# Usage: verify_files_exist <gitdir> <refdir>
>> +# <gitdir> is the path for the gitdir.
>> +# <refdir> is the path for the refdir.
>> +verify_files_exist() {
>> + gitdir=$1 &&
>> + refdir=$2 &&
>> +
>> + # verify that the stubs were added to the $GITDIR.
>> + cat $gitdir/refs/heads >actual &&
>> + echo "repository uses alternate refs storage" >expect &&
>> + test_cmp expect actual &&
>
> Tiny nit, not worth addressing on its own: we could simply `test_cmp
> expect "$gitdir/refs/heads", without the need to copy that file first.
>Indeed. I'll make this change locally, but hold off on re-rolling for now.
Show 9 quoted lines
>> + cat $gitdir/HEAD >actual && >> + echo "ref: refs/heads/.invalid" >expect && >> + test_cmp expect actual > > Same here, no need to copy the file around. > > Other than that I'm happy with this patch series now, thanks! > > Patrick
I'm also quite happy with how its turned out. Thanks for the continuous reviews.
Karthik