Re: [PATCH 3/3] wt-status: use hash_algo from local repository instead of global the_hash_algo

From: Karthik Nayak <karthik.188@gmail.com>
Date: Feb 2, 2026, 10:03 UTC
Message-ID: <CAOLa=ZT6ReeaPvJiNh967Sn2p3K8sQKEOOMJ+6-7ZdFO+wr8mg@mail.gmail.com>
In-Reply-To: <20260131190106.389289-4-shreyanshpaliwalcmsmn@gmail.com>

Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:

Show 9 quoted lines

> wt-status.c uses the global the_hash_algo even though a repository
> instance is already available via struct repository *r.
>
> Replace uses of the_hash_algo with the hash algorithm stored in the
> associated repository (r->hash_algo).
>
> This removes another dependency on global state and keeps wt-status
> consistent with local repository usage.
>

One final question is, does this mean we can remove `USE_THE_REPOSITORY_VARIABLE` after these changes? If not, why?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.