Re: [PATCH v4 1/2] clang-format: re-adjust line break penalties

From: karthik nayak <karthik.188@gmail.com>
Date: Oct 25, 2024, 09:48 UTC
Message-ID: <CAOLa=ZT0h+R83vf7tzSQLw56TU2nW16PpbMGg6tkWoTYYpbLcQ@mail.gmail.com>
In-Reply-To: <xefdxe2vctdtmfm3vfanstfz5q2bgcklj7ymio5bdutioyaxmo@ujixbc5jua6m>

Justin Tobler <jltobler@gmail.com> writes:

Show 10 quoted lines

> On 24/10/18 10:46AM, Karthik Nayak wrote:
>> In 42efde4c29 (clang-format: adjust line break penalties, 2017-09-29) we
>> adjusted the line break penalties to really fine tune what we care about
>> while doing line breaks. Modify some of those to be more inline with
>> what we care about in the Git project now.
>
> From my understanding, the original motivation for these changes was to
> cut down on the noise from the clang-format CI job. These changes seem
> reasonable for that purpose, but affect the also formatter in general.
>

Yes, you're right. Which is the intended affect.

Show 5 quoted lines

> Out of curiousity, would it be possible to just configured clang-format
> for the CI job to behave in this manner? Ultimately, I'm not sure that
> would be good idea though because having a diverged set of rules may
> just cause more noise.
>

We do that in 'ci/run-style-check.sh' already, but here I'd say there is no need to diverge. We do want users to apply clang-format to _their_ changes, which should be similar to what the CI barfs.