git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/2] attr: add flag `--source` to work with tree-ish

From
Karthik Nayak <karthik.188@gmail.com>
Date
Jan 4, 2023, 10:25 UTC
Message-ID
<CAOLa=ZStKKgyaHGjGVpQ5jsSpkdqXuH2RhvWOgrU2qKxGbQFGA@mail.gmail.com>
In-Reply-To
<xmqq1qocwlr9.fsf@gitster.g>
On Tue, Jan 3, 2023 at 12:38 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
>
> Likewise.
>
> Perhaps squash something like this in in the next iteration?
>
>  attr.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git i/attr.h w/attr.h
> index 84a3279215..fca6c30430 100644
> --- i/attr.h
> +++ w/attr.h
> @@ -108,6 +108,7 @@
>   */
>
>  struct index_state;
> +struct object_id;
>
>  /**
>   * An attribute is an opaque object that is identified by its name. Pass the

Thanks Junio, I'll squash this in, waiting for more reviews before rolling out a new version.

-- 
- Karthik
Previous: Junio C HamanoNext: Phillip Wood
Message 5 of 10 in “check-attr: add support to work with tree-ish”
  1. 0/2 check-attr: add support to work with tree-ishKarthik Nayak, Jan 2, 2023
  2. 1/2 t0003: move setup for `--all` into new blockKarthik Nayak, Jan 2, 2023
  3. 2/2 attr: add flag `--source` to work with tree-ishKarthik Nayak, Jan 2, 2023
  4. Junio C HamanoJan 2, 2023
  5. Karthik NayakJan 4, 2023
  6. Phillip WoodJan 11, 2023
  7. Karthik NayakJan 12, 2023
  8. Ævar Arnfjörð BjarmasonJan 12, 2023
  9. Karthik NayakJan 14, 2023
  10. Karthik NayakJan 9, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.