git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] api-parse-options: add missing flags and macros

From
Karthik Nayak <karthik.188@gmail.com>
Date
Nov 5, 2026, 13:56 UTC
Message-ID
<CAOLa=ZSfNPt03R2F_xG930pBmXCJ-CcC-GnTTLA5AgWoZm8eaQ@mail.gmail.com>
In-Reply-To
<20261105122532.391-1-herroyalpriestess@gmail.com>
Cynthia Uche <herroyalpriestess@gmail.com> writes:
Show 8 quoted lines
> Hi Karthik,
>
> On Thu, Nov 5, 2026 at 11:37 AM Karthik Nayak <karthik.188@gmail.com> wrote:
>
>> Also add the follow missing macros:
>
> nit: s/follow/following/.
>
Will swap out.
Show 7 quoted lines
>> - OPT_NO_WITH
>
> The message lists OPT_NO_WITH, but parse-options.h defines
> OPT_WITHOUT, which is what the diff documents. The diff also adds
> OPT_BITOP, OPT_STRVEC, OPT_UYN, OPT_NOOP_ARG and OPT_COLUMN, which
> the message doesn't list.
>
Ah right, let me fix all this up.
Show 6 quoted lines
> I applied this on its base (8d1b215c01), built the docs with no
> warnings, and compared the descriptions with the code on master
> (0ffa3e35c7). OPT__VERBOSITY, OPT_UYN, OPT_BITOP, OPT_COLUMN,
> OPT_CONTAINS, OPT_NOOP_ARG and the two new flags match
> parse-options.c and parse-options-cb.c, and the git-add[1]
> references resolve via diff-context-options.adoc.

Seems like I forgot to update the commit message after making some changes. Will update it.

Thanks for testing.
> OPT_ALIAS and OPT_ALIAS_F are still undocumented tho. I wonder if that
> is on purpose.
>

We don't add the '_F' versions as we talk about all such variants at the top. But will add in `OPT_ALIAS`.

> --
> Cynthia
Previous: Cynthia UcheNext: Cynthia Uche
Message 3 of 10 in “api-parse-options: add missing flags and macros”
  1. api-parse-options: add missing flags and macrosKarthik Nayak, Nov 5, 2026
  2. Cynthia UcheNov 5, 2026
  3. Karthik NayakNov 5, 2026
  4. Cynthia UcheNov 5, 2026
  5. api-parse-options: add missing flags and macrosKarthik Nayak, Nov 6, 2026
  6. Cynthia UcheNov 6, 2026
  7. Karthik NayakNov 9, 2026
  8. api-parse-options: add missing flags and macrosKarthik Nayak, Nov 9, 2026
  9. Junio C HamanoNov 9, 2026
  10. Karthik NayakNov 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.