git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 03/11] ref-filter: add option to pad atoms to the right

From
Karthik Nayak <karthik.188@gmail.com>
Date
Aug 1, 2015, 06:03 UTC
Message-ID
<CAOLa=ZSXM3CmtVvVFRvQ340fKAKPHvPo64r41CSvoXrFz+wm9w@mail.gmail.com>
In-Reply-To
<CAPig+cR709U7zy3+F4eoiyUBhA=c2ZCxPc9uUoDQLOuooFxvzQ@mail.gmail.com>
On Thu, Jul 30, 2015 at 11:26 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 18 quoted lines
>
> In an earlier review, Matthieu pointed out that this test failed to
> ensure that the 'padright' value did not leak into the next atom. In a
> subsequent version, you fixed the test to check that condition, but
> now you've somewhat lost it again, at least visually. That is, because
> whitespace is "invisible" and because 'padright' now also affects
> literal strings, someone reading this test can't tell if those
> trailing |'s in the expected output are padded or not. You could use a
> different format string to prove that the 'padright' value doesn't
> leak. For instance:
>
>     %(padright:10)%(refname:short)|%(padright:5)|%(refname:short)
>
> This way, as long as the two |'s are side-by-side, then you've proved
> that the first one wasn't affected by the preceding 'padright:10'. You
> could also add back the %(refname:short) at the front of the pattern,
> as you currently have it, if you want to prove that padding is not
> enabled at the start of format.

Thanks Eric. This seems like a better improvement over my test. Will implement this :)

-- 
Regards,
Karthik Nayak
Previous: Eric SunshineNext: Karthik Nayak
Message 6 of 17 in “port tag.c to use ref-filter APIs”
  1. 0/11 port tag.c to use ref-filter APIsKarthik Nayak, Jul 30, 2015
  2. 01/11 ref-filter: introduce 'ref_formatting_state'Karthik Nayak, Jul 30, 2015
  3. 02/11 ref-filter: make `color` use `ref_formatting_state`Karthik Nayak, Jul 30, 2015
  4. 03/11 ref-filter: add option to pad atoms to the rightKarthik Nayak, Jul 30, 2015
  5. Eric SunshineJul 30, 2015
  6. Karthik NayakAug 1, 2015
  7. 04/11 ref-filter: add option to filter only tagsKarthik Nayak, Jul 30, 2015
  8. 05/11 ref-filter: support printing N lines from tag annotationKarthik Nayak, Jul 30, 2015
  9. 06/11 ref-filter: add support to sort by versionKarthik Nayak, Jul 30, 2015
  10. 07/11 ref-filter: add option to match literal patternKarthik Nayak, Jul 30, 2015
  11. 08/11 tag.c: use 'ref-filter' data structuresKarthik Nayak, Jul 30, 2015
  12. 09/11 tag.c: use 'ref-filter' APIsKarthik Nayak, Jul 30, 2015
  13. 10/11 tag.c: implement '--format' optionKarthik Nayak, Jul 30, 2015
  14. 11/11 tag.c: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jul 30, 2015
  15. Karthik NayakJul 30, 2015
  16. Matthieu MoyAug 2, 2015
  17. Karthik NayakAug 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.