Re: [PATCH] ref-filter: fallback on alphabetical comparison

From: Karthik Nayak <karthik.188@gmail.com>
Date: Oct 25, 2015, 07:15 UTC
Message-ID: <CAOLa=ZSS3QK8wkKUGCtLqhoZATCxJxpYBvPCUf37KHVwZeRsOg@mail.gmail.com>
In-Reply-To: <CAPig+cRnDNFCQs6qspKDEz6C0Rum8W0tSMxejw+WOBD=XHrDxw@mail.gmail.com>

On Sun, Oct 25, 2015 at 5:48 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 11 quoted lines

> On Sat, Oct 24, 2015 at 10:42 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> In ref-filter.c the comparison of refs while sorting is handled by
>> cmp_ref_sorting() function. When sorting as per numerical values
>> (e.g. --sort=objectsize) there is no fallback comparison when both refs
>> hold the same value. This can cause unexpected results as pointed out
>> by Johannes Sixt ($gmane/280117).
>
> Please make the commit message self-contained by describing the
> "unexpected results" here rather than directing readers to chase down
> the information elsewhere themselves.
>

Will do.

Show 7 quoted lines

>> Hence, fallback to alphabetical comparison based on the refname whenever
>> the other criterion is equal. Fix the test in t3203 in this regard.
>>
>> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
>
> It would not be amiss to add a Reported-by: to credit j6t.
>

Definitely. Thanks for the quick review :)

-- 
Regards,
Karthik Nayak