git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] check-ref-format: use parse-options API

From
Karthik Nayak <karthik.188@gmail.com>
Date
Nov 3, 2026, 10:00 UTC
Message-ID
<CAOLa=ZS3ULcNVjV1DMO-iB+LcC2Gnw+9oU2_7VXKoLvgiVRnbg@mail.gmail.com>
In-Reply-To
<pull.2470.v2.git.git.1793694813386.gitgitgadget@gmail.com>
"Husain Sitamuwala via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 19 quoted lines
> From: Hussain Sitamouwala <husainsitamuwala21@gmail.com>
>
> The command parses its options by hand, comparing each argument
> against string literals. Use the parse-options API instead so that
> option handling is consistent with other builtins and the help
> output is generated from the option table.
>
> Keep the existing behavior: --print stays a hidden, deprecated
> synonym for --normalize, only --allow-onelevel can be negated, and
> parsing stops at the first non-option argument so that options
> after <refname> are still rejected.
>
> Drop the early show_usage_if_asked() call, so that -h is handled by
> parse_options().
>
> Two minor differences come with parse_options(): unambiguous
> abbreviations of long options, such as --norm, are accepted, and
> "--" may now precede <refname>.
>

If you follow our 'Documentation/SubmittingPatches' guidelines, it states:

  It is often beneficial to allow some time for reviewers to provide
  feedback before sending a new version, rather than sending an updated
  series immediately after receiving a review. This helps collect
  broader input, gives reviewers in different time zones a fair chance
  to comment, and avoids unnecessary churn from many rapid iterations.
  Waiting also encourages you to polish each version before sending it,
  so reviewers can focus on substantial issues rather than typos or
  other small mistakes.

Seems like Junio's review went unanswered. Which makes it hard for me to consider dedicating time to do another review of the newer version. I would suggest that you engage in the process before sending new versions. I'll hold off reviewing till then :)

[snip]
Previous: Husain Sitamuwala via GitGitGadgetNext: Junio C Hamano
Message 4 of 6 in “check-ref-format: use parse-options API”
  1. check-ref-format: use parse-options APIHusain Sitamuwala via GitGitGadget, Oct 29, 2026
  2. Junio C HamanoOct 29, 2026
  3. check-ref-format: use parse-options APIHusain Sitamuwala via GitGitGadget, Nov 3, 2026
  4. Karthik NayakNov 3, 2026
  5. Junio C HamanoNov 3, 2026
  6. Hussain SitamouwalaNov 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.