Re: [PATCH v6 01/10] ref-filter: introduce 'ref_formatting_state'

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jul 29, 2015, 15:56 UTC
Message-ID: <CAOLa=ZS=bMnVDjGL0vb08t2XCTqH7tG9+QuPyz3D9wb7hCbpaA@mail.gmail.com>
In-Reply-To: <vpqwpxk215y.fsf@anie.imag.fr>

On Tue, Jul 28, 2015 at 12:56 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 22 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> -static void print_value(struct atom_value *v, int quote_style)
>> +static void apply_formatting_state(struct ref_formatting_state *state,
>> +                                struct atom_value *v, struct strbuf *value)
>>  {
>> -     struct strbuf sb = STRBUF_INIT;
>> -     switch (quote_style) {
>> +     /*  Eventually we'll formatt based on the ref_formatting_state */
>
> s/formatt/format/
>
> Also, we usually use a single space after /*.
>
> (Neither is very important since it disapears in the next commit)
>
>> +     /*
>> +      * Some (pesudo) atoms have no immediate side effect, but only
>
> s/pesudo/pseudo/. But if you are to rename these atoms to "modifier
> atoms", you should get rid of this "pseudo" here.
>

Ah, I hate making grammatical errors, Even though I check it always gets away. Anyways waiting for Junio and others to reply on this version. Could do a resend for this series if needed.

-- 
Regards,
Karthik Nayak