git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/2] attr: add flag `--revision` to work with revisions

From
Karthik Nayak <karthik.188@gmail.com>
Date
Dec 23, 2022, 10:44 UTC
Message-ID
<CAOLa=ZRb65r8ifhnNqGv0Mhq1=R-71X5NYgjBLiBkEBhn+nT=g@mail.gmail.com>
In-Reply-To
<CAPig+cTHJzHsUum0RnyCcqxj1qhxJR9EcKRjoShCznQ_oXYHOA@mail.gmail.com>
On Wed, Dec 21, 2022 at 10:13 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 16 quoted lines
>
> On Wed, Dec 21, 2022 at 3:58 PM Phillip Wood <phillip.wood123@gmail.com> wrote:
> > On 21/12/2022 13:47, Karthik Nayak wrote:
> > > Since we use a tree-ish object, the user can pass "--revision
> > > HEAD:subdirectory" and all the attributes will be looked up as if
> > > subdirectory was the root directory of the repository.
> >
> > We should be clear in the documentation and option help that --revision
> > takes a tree-ish (i.e. --revision=<tree-ish>). Maybe calling the option
> > --tree would be clearer.
>
> If that's the case, shouldn't this be called --source (or some
> variation thereof) for consistency[1] with git-restore?
>
> [1]: https://lore.kernel.org/git/CAPig+cT_xz3m-3kkL_Scf0opNXkikU94kSF46VO8KHkNMWbGzg@mail.gmail.com/
>

Let me rename it to source, and we can discuss on the next version if the name suits or not.

-- 
- Karthik
Previous: Phillip WoodNext: Karthik Nayak
Message 7 of 8 in “check-attr: add support to work with revisions”
  1. 0/2 check-attr: add support to work with revisionsKarthik Nayak, Dec 21, 2022
  2. 1/2 t0003: move setup for `--all` into new blockKarthik Nayak, Dec 21, 2022
  3. 2/2 attr: add flag `--revision` to work with revisionsKarthik Nayak, Dec 21, 2022
  4. Phillip WoodDec 21, 2022
  5. Eric SunshineDec 21, 2022
  6. Phillip WoodDec 22, 2022
  7. Karthik NayakDec 23, 2022
  8. Karthik NayakDec 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.