Re: [PATCH 01/16] path: refactor `repo_common_path()` family of functions

From: Karthik Nayak <karthik.188@gmail.com>
Date: Feb 6, 2025, 11:17 UTC
Message-ID: <CAOLa=ZRSSnqRO_=N-sVrYSRpCZkyW0KFh5=rwX0NY_VqyzKz3A@mail.gmail.com>
In-Reply-To: <20250206-b4-pks-path-drop-the-repository-v1-1-4e77f0313206@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

[snip]

Show 10 quoted lines

> diff --git a/path.c b/path.c
> index 07964f5d32..273b649e00 100644
> --- a/path.c
> +++ b/path.c
> @@ -414,7 +414,7 @@ static void strbuf_worktree_gitdir(struct strbuf *buf,
>  	else if (!wt->id)
>  		strbuf_addstr(buf, repo->commondir);
>  	else
> -		strbuf_git_common_path(buf, repo, "worktrees/%s", wt->id);
> +		repo_common_path_append(repo, buf, "worktrees/%s", wt->id);

This is the only place we replace `strbuf_git_common_path` with `repo_common_path_append`, whereas other places it is `repo_common_path_replace`. I assume that is because in those places the buf is newly initialized.

[snip]

Rest of the patch looks good!