Re: [PATCH 1/2] reflog: drop usage of global variables

From: Karthik Nayak <karthik.188@gmail.com>
Date: Mar 13, 2025, 13:30 UTC
Message-ID: <CAOLa=ZQq6ax6Ba4gLN8P_TTV-KOrfN5yyNJB98oFx4fd9SFkhQ@mail.gmail.com>
In-Reply-To: <xmqqsenkaoy3.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>> but I also suspect that it is mostly due to the original program
>>> structure that uses OPT_SUBCOMMAND() that the subcommands fail to
>>> respond to "-h" unlike the top-level command, so this may not be a
>>> regression.  I do think however that this change is making it harder
>>> to fix.
>>>
>>
>> Hmm. But this is the existing behavior, no?
>
> Didn't I said I also suspect?
>

Yes, I misunderstood!

Show 8 quoted lines

>> But point taken, I'll drop this patch in the next version! Thanks
>
> Yup.  Take your time, as it is already deep in prerelease feature
> freeze.  I'd prefer to see us leaving spare capacity in our minds to
> fix regressions introduced during this period once they are noticed,
> without getting distracted by shiny new toys.
>
> Thanks.

Fair enough. I only pushed this new topic, because I had mentioned to you that I would pick it up and I didn't want to forget about it.

Either ways, I will take it slow here! :)