Re: [PATCH 1/6] refs: remove unused header

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jan 15, 2026, 09:50 UTC
Message-ID: <CAOLa=ZQfjb1OfHJp6MVkbs=5Wey4Gp6t-jmEQSrojOsp=ge-Jw@mail.gmail.com>
In-Reply-To: <xmqqwm1kf7gr.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Some of the headers in 'refs.c' are no longer required, let's remove
>> them.
>>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> ---
>>  refs.c | 2 --
>>  1 file changed, 2 deletions(-)
>
> One thing to note is that The resulting file refs.c still includes
> hook.h and because of that, the removal of run-command.h from here
> has no effect.
>

Good point, let me modify the commit message to explain this better. Perhaps:

-->8--

refs: drop unnecessary header includes

The 'sigchain.h' header isn't being used and can be removed.

Similarly, 'run-command.h' serves no direct purpose here. While it gets pulled in transitively through 'hook.h', we can still drop the explicit include for clarity.

Show 20 quoted lines

>> diff --git a/refs.c b/refs.c
>> index e06e0cb072..965b232a06 100644
>> --- a/refs.c
>> +++ b/refs.c
>> @@ -15,7 +15,6 @@
>>  #include "iterator.h"
>>  #include "refs.h"
>>  #include "refs/refs-internal.h"
>> -#include "run-command.h"
>>  #include "hook.h"
>>  #include "object-name.h"
>>  #include "odb.h"
>> @@ -26,7 +25,6 @@
>>  #include "strvec.h"
>>  #include "repo-settings.h"
>>  #include "setup.h"
>> -#include "sigchain.h"
>>  #include "date.h"
>>  #include "commit.h"
>>  #include "wildmatch.h"