Re: [PATCH 01/10] ref-filter: add option to filter only branches
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Aug 13, 2015, 15:13 UTC
- Message-ID
- <CAOLa=ZQSVCgcuUQFsF2Mq-m+wS8im3t4Z3PSEgoAHcV0gGuvPA@mail.gmail.com>
- In-Reply-To
- <CAOLa=ZQic2=z6bJ0Ykhn2x8mE86w4HwBrJP7pb_RaemGKCZzmQ@mail.gmail.com>
On Thu, Aug 13, 2015 at 5:05 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
Show 19 quoted lines
> On Thu, Aug 13, 2015 at 4:21 PM, Karthik Nayak <karthik.188@gmail.com> wrote: >> >> This was taken from branch.c, I thought of using an enum instead but that >> would again require most of branch.c, hence it's been carried over >> without changing >> I'm thinking of changing it, any suggestions? >> > > What I was thinking was of having: > > #define FILTER_REFS_INCLUDE_BROKEN 0x1 > #define FILTER_REFS_TAGS 0x2 > #define FILTER_REFS_BRANCHES 0x4 > #define FILTER_REFS_REMOTES 0x8 > #define FILTER_REFS_DETACHED_HEAD 0x16 > > and using these for showing ref kind also instead of separately > having 'REF_DETACHED_HEAD' and so on. >
Something like this: https://github.com/KarthikNayak/git/commit/0ec5381420dcdfe7c62000b56168e2842d5d0063
-- Regards, Karthik Nayak