Re: [PATCH 1/2] update-ref: use {old,new}-oid instead of {old,new}value
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Apr 1, 2024, 22:38 UTC
- Message-ID
- <CAOLa=ZQRw1Cu9rcKYoxzsL8V3LWjyMKuOkcutzqRJb+cpyBNTA@mail.gmail.com>
- In-Reply-To
- <xmqqo7as957h.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 21 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> From: Karthik Nayak <karthik.188@gmail.com>
>>
>> The `git-update-ref` command is used to modify references. The usage of
>> {old,new}value in the documentation refers to the OIDs. This is fine
>> since the command only works with regular references which hold OIDs.
>> But if the command is updated to support symrefs, we'd also be dealing
>> with {old,new}-refs.
>>
>> To improve clarity around what exactly {old,new}value mean, let's rename
>> it to {old,new}-oid.
>>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> ---
>> Documentation/git-update-ref.txt | 58 ++++++++++++++++----------------
>> builtin/update-ref.c | 26 +++++++-------
>> 2 files changed, 42 insertions(+), 42 deletions(-)
>
> Did you run t1400 after this update? There may be other tests that
> the message update is breaking but that was the first one I noticed.I definitely didn't. It totally slipped my mind, I was thinking that I only modified the *.txt files. I will send in a new version after ensuring all tests are fixed.