git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] update-ref: use {old,new}-oid instead of {old,new}value

From
Karthik Nayak <karthik.188@gmail.com>
Date
Apr 1, 2024, 22:38 UTC
Message-ID
<CAOLa=ZQRw1Cu9rcKYoxzsL8V3LWjyMKuOkcutzqRJb+cpyBNTA@mail.gmail.com>
In-Reply-To
<xmqqo7as957h.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 21 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> From: Karthik Nayak <karthik.188@gmail.com>
>>
>> The `git-update-ref` command is used to modify references. The usage of
>> {old,new}value in the documentation refers to the OIDs. This is fine
>> since the command only works with regular references which hold OIDs.
>> But if the command is updated to support symrefs, we'd also be dealing
>> with {old,new}-refs.
>>
>> To improve clarity around what exactly {old,new}value mean, let's rename
>> it to {old,new}-oid.
>>
>> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
>> ---
>>  Documentation/git-update-ref.txt | 58 ++++++++++++++++----------------
>>  builtin/update-ref.c             | 26 +++++++-------
>>  2 files changed, 42 insertions(+), 42 deletions(-)
>
> Did you run t1400 after this update?  There may be other tests that
> the message update is breaking but that was the first one I noticed.

I definitely didn't. It totally slipped my mind, I was thinking that I only modified the *.txt files. I will send in a new version after ensuring all tests are fixed.

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 11 in “improve documentation around git-update-ref”
  1. 0/2 improve documentation around git-update-refKarthik Nayak, Apr 1, 2024
  2. 1/2 update-ref: use {old,new}-oid instead of {old,new}valueKarthik Nayak, Apr 1, 2024
  3. Junio C HamanoApr 1, 2024
  4. Karthik NayakApr 1, 2024
  5. Junio C HamanoApr 1, 2024
  6. Karthik NayakApr 2, 2024
  7. 2/2 githooks: use {old,new}-oid instead of {old,new}-valueKarthik Nayak, Apr 1, 2024
  8. 0/2 improve documentation around git-update-refKarthik Nayak, Apr 2, 2024
  9. 2/2 githooks: use {old,new}-oid instead of {old,new}-valueKarthik Nayak, Apr 2, 2024
  10. 1/2 update-ref: use {old,new}-oid instead of {old,new}valueKarthik Nayak, Apr 2, 2024
  11. Patrick SteinhardtApr 2, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.