git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] install meson for Documentation job

From
Karthik Nayak <karthik.188@gmail.com>
Date
Mar 19, 2025, 16:22 UTC
Message-ID
<CAOLa=ZQHZEh=vzxUqBLmVDn3LWFrch0BtRAYMssLO9hL9a5sJg@mail.gmail.com>
In-Reply-To
<Z9qNNq0p10YJCZYo@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 43 quoted lines
> On Tue, Mar 18, 2025 at 01:40:07PM -0700, Junio C Hamano wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>> > Weird. From the looks of
>> > https://github.com/git/git/actions/runs/13867157977/job/38808418127, it
>> > seems like the '$distro' variable in 'ci/install-dependencies.sh' is not
>> > being correctly initialized. We can see this in the logs of the CI:
>> >
>> >   CI setup via install-dependencies.sh
>> >     + set -e
>> >     + export TERM=dumb
>> >     + export MAKEFLAGS=
>> >     + test true = true
>> >     + CI_TYPE=github-actions
>> >     + CI_BRANCH=refs/heads/seen
>> >     + CI_COMMIT=d5389e37e21d864f40f4167280db799ffe8983c2
>> >     + echo Linux
>> >     + tr A-Z a-z
>> >     + CI_OS_NAME=linux
>> >     + test macos != linux
>> >     + CI_REPO_SLUG=git/git
>> >     + CI_JOB_ID=13867157977
>> >     + CC=gcc
>> >     + DONT_SKIP_TAGS=t
>> >     + cache_dir=/home/runner/none
>> >     + GIT_TEST_OPTS=--github-workflow-markup
>> >     + JOBS=10
>> >     + echo
>> >     + tr : -
>> >     + distro=
>> >     ...
>>
>> Nice digging.
>
> Thanks all for discovering and debugging this, I somehow missed this
> thread and haven't been able to keep up with the mailing list for the
> last couple days.
>
> I see 4451a164e5a (install meson for Documentation job, 2025-03-14) has
> been merged, but as far as I understand we also have to take Karthik's
> patch to fix installing dependencies? In case I'm correct, do you plan
> to send this as a proper patch, Karthik?
>

I had a patch locally and after your mail, I did test it out on GitHub [1]. Will send it here, this should fix the issue and replace 4451a164e5a.

[1]: https://github.com/git/git/actions/runs/13944424140/job/39028258830?pr=1927
> Patrick
Previous: Patrick SteinhardtNext: Karthik Nayak
Message 9 of 15 in “What's cooking in git.git (Mar 2025, #04; Fri, 14)”
  1. Junio C HamanoMar 14, 2025
  2. Jeff KingMar 14, 2025
  3. Jeff KingMar 14, 2025
  4. Junio C HamanoMar 15, 2025
  5. install meson for Documentation jobJunio C Hamano, Mar 18, 2025
  6. Karthik NayakMar 18, 2025
  7. Junio C HamanoMar 18, 2025
  8. Patrick SteinhardtMar 19, 2025
  9. Karthik NayakMar 19, 2025
  10. ci/github: add missing 'CI_JOB_IMAGE' env variableKarthik Nayak, Mar 19, 2025
  11. Patrick SteinhardtMar 20, 2025
  12. Junio C HamanoMar 21, 2025
  13. Junio C HamanoMar 20, 2025
  14. en/diff-rename-follow-fix (Was: Re: What's cooking in git.git (Mar 2025, #04; Fri, 14))Elijah Newren, Mar 15, 2025
  15. Junio C HamanoMar 15, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.