Re: [PATCH v2] ref-filter: fallback on alphabetical comparison

From: Karthik Nayak <karthik.188@gmail.com>
Date: Oct 26, 2015, 17:13 UTC
Message-ID: <CAOLa=ZQGwrQrie+Bp0B61LdG37-UeEdyHqvQEtq26nX9VjYu7Q@mail.gmail.com>
In-Reply-To: <CAPig+cRRB5MNxuBc-5rM_8cJh69PjH5-OSmkRNw_6OFQdQOoTw@mail.gmail.com>

On Mon, Oct 26, 2015 at 6:43 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 8 quoted lines

> On Sun, Oct 25, 2015 at 12:29 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> In ref-filter.c the comparison of refs while sorting is handled by
>> cmp_ref_sorting() function. When sorting as per numerical values
>> (e.g. --sort=objectsize) there is no fallback comparison when both
>> refs hold the same value. This can cause unexpected results (i.e. the
>> order of listting refs with equal values cannot be pre-determined) as
>
> s/listting/listing/

Thanks for pointing out. Should I re-roll?

-- 
Regards,
Karthik Nayak