Re: [PATCH v2 0/3] config: fix segfault when parsing "core.abbrev" without repo

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jun 12, 2024, 09:29 UTC
Message-ID: <CAOLa=ZQBmp3Aj135HppKzkcVhpNC40JgtX6YN6Dam34cmeSg5Q@mail.gmail.com>
In-Reply-To: <cover.1718178996.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 19 quoted lines

> Hi,
>
> this is the second version of my patch series that fixes a segfault when
> parsing "core.abbrev" without a repository.
>
> Changes compared to v1:
>
>   - Stop truncating the abbreviation length to the upper boundary
>     completely. It's unnecessary, complicates the code and makes us
>     dependent on `the_repository`.
>
>   - Adapt `parse_opt_abbrev_cb()` to also stop truncating such that the
>     behaviour of "core.abbrev" and `--abbrev` is the same.
>
>   - Extend test coverage a bit.
>
> Thanks!
>
> Patrick

The changes look good, I wasn't expecting a benchmark in the last commit for such a small change, but that was nice to see. Thanks.

[snip]