Re: [PATCH 4/9] reftable/block: introduce `block_reader_release()`
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Apr 3, 2024, 13:16 UTC
- Message-ID
- <CAOLa=ZQ4Vq7YfUsh4mky8HsEurp3RyUEXsZS7tDU0XMc+6Gv0w@mail.gmail.com>
- In-Reply-To
- <9a1253649a4dc993da7caced2f15839d988905d9.1711519925.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 14 quoted lines
>
> diff --git a/reftable/reader.c b/reftable/reader.c
> index f70efa2b7c..f925570bf3 100644
> --- a/reftable/reader.c
> +++ b/reftable/reader.c
> @@ -253,7 +253,7 @@ static void table_iter_block_done(struct table_iter *ti)
> if (!ti->bi.br) {
> return;
> }
> - reftable_block_done(&ti->bi.br->block);
> + block_reader_release(ti->bi.br);
> FREE_AND_NULL(ti->bi.br);
>
> ti->bi.last_key.len = 0;I would expect `FREE_AND_NULL(ti->bi.br)` to also be within `block_reader_release`, but then you'd have to pass `table_iter` or `**`. So I guess this is okay.