Re: [PATCH v3] ls-files: introduce "--format" option
- From
ZheNing Hu <adlternative@gmail.com>
- Date
- Jun 26, 2022, 13:35 UTC
- Message-ID
- <CAOLTT8Tc95-aUE+uN2d8QjTJpGpGw6cBJfG+bpmyE55OcXTSRA@mail.gmail.com>
- In-Reply-To
- <xmqqsfnuvzxc.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> 于2022年6月24日周五 23:33写道：
Show 36 quoted lines
> > Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > > > On Tue, Jun 21 2022, ZheNing Hu via GitGitGadget wrote: > >> + if (skip_prefix(start, "(objectmode)", &p)) > >> + strbuf_addf(sb, "%06o", data->ce->ce_mode); > >> + else if (skip_prefix(start, "(objectname)", &p)) > >> + strbuf_add_unique_abbrev(sb, &data->ce->oid, abbrev); > >> + else if (skip_prefix(start, "(stage)", &p)) > >> + strbuf_addf(sb, "%d", ce_stage(data->ce)); > >> + else if (skip_prefix(start, "(path)", &p)) > >> + write_name_to_buf(sb, data->pathname); > > These are just "values". > > >> + else if (skip_prefix(start, "(ctime)", &p)) > >> + strbuf_addf(sb, "ctime: %u:%u", > >> + sd->sd_ctime.sec, sd->sd_ctime.nsec); > >> + else if (skip_prefix(start, "(mtime)", &p)) > >> + strbuf_addf(sb, "mtime: %u:%u", > >> + sd->sd_mtime.sec, sd->sd_mtime.nsec); > >> + else if (skip_prefix(start, "(dev)", &p)) > >> + strbuf_addf(sb, "dev: %u", sd->sd_dev); > >> + else if (skip_prefix(start, "(ino)", &p)) > >> + strbuf_addf(sb, "ino: %u", sd->sd_ino); > >> + else if (skip_prefix(start, "(uid)", &p)) > >> + strbuf_addf(sb, "uid: %u", sd->sd_uid); > >> + else if (skip_prefix(start, "(gid)", &p)) > >> + strbuf_addf(sb, "gid: %u", sd->sd_gid); > >> + else if (skip_prefix(start, "(size)", &p)) > >> + strbuf_addf(sb, "size: %u", sd->sd_size); > >> + else if (skip_prefix(start, "(flags)", &p)) > >> + strbuf_addf(sb, "flags: %x", data->ce->ce_flags); > > These are not. >
Agree. So I just remove them as you see. If someone else need them for some reason, we can add them back.
ZheNing Hu