Re: [PATCH v2 1/2] docs: fix sparse-checkout docs link
- From
ZheNing Hu <adlternative@gmail.com>
- Date
- Jan 23, 2023, 15:16 UTC
- Message-ID
- <CAOLTT8T5XaTH0APobqLo8+nUuBwmMkGKGOc7GdRx81kdxb6NGw@mail.gmail.com>
- In-Reply-To
- <CAN0heSoVguXpGC4PMsvh8CedwSvxu8A=iG2hT8Szxdq2ivh9rw@mail.gmail.com>
Martin Ågren <martin.agren@gmail.com> 于2023年1月20日周五 17:35写道:
Show 30 quoted lines
> > On Fri, 20 Jan 2023 at 06:29, Elijah Newren <newren@gmail.com> wrote: > > > > On Thu, Jan 19, 2023 at 9:34 AM ZheNing Hu via GitGitGadget > > <gitgitgadget@gmail.com> wrote: > > > > > > From: ZheNing Hu <adlternative@gmail.com> > > > So fix the format of sparse-checkout.txt, and link it in the > > > Makefile to correct that. > > > > -0. Behavior A is not well supported in Git. (Behavior B didn't used to > > > - be either, but was the easier of the two to implement.) > > > +Behavior A is not well supported in Git. (Behavior B didn't used to > > > +be either, but was the easier of the two to implement.) > > > > Why did you remove the numbering on this, though? If asciidoc doesn't > > like starting with 0 (the only guess I can think of for why you'd > > change this), shouldn't the series be renumbered starting at 1 rather > > than removing this from the list? > > It looks like the zero causes both asciidoc and Asciidoctor to emit > warnings (one per item, since each item's number is off by one). They > also helpfully relabel everything starting at 1. > > I agree that there's a better fix here than dropping the 0. Either > renumber everything or, probably better, just use "." for each item > rather than "1.", "2." and so on. The right numbers will be inserted > automatically. This also means that if an item is ever added earlier in > the list, we won't need to update all the numbers below that point. >
Good idea.
Show 5 quoted lines
> (The numbers being generated automatically means we can't refer to them
> ("see item 2") without potentially getting out of sync, but that is true
> regardless if the numbers are corrected for us, as now, or if we just
> use ".".)
>That shouldn't matter, there are no references to any of these items.
Show 6 quoted lines
> The contents of these list items could be prettified in various ways, > but I'm not sure what the status and goal is for these technical/ > documents. Avoiding warnings in the build process, as ZheNing aimed for, > seems like a good idea regardless. > > Martin
Thanks, -- ZheNing Hu