Re: GSoC Git Proposal Draft - ZheNing Hu

From: ZheNing Hu <adlternative@gmail.com>
Date: Apr 11, 2021, 15:34 UTC
Message-ID: <CAOLTT8SW0n=x3HBL=php0aC1nhP7eU-MHFLustC3H0opxGRV1w@mail.gmail.com>
In-Reply-To: <CAOLTT8RTA0inxgxbd3qDToKYxwgXGKvJikXWsXg7oQ4asFj+HQ@mail.gmail.com>

Hi, Peff,

> Why is Olga’s solution rejected?
> 1. Olga's solution is to let `git cat-file` use the `ref-filter` interface,
> the performance of `cat-file` appears to be degraded due "very eager to
> allocate lots of separate strings" in `ref-filter` and other reasons.

I am thinking today whether we can directly append some object information directly to `&state->stack->output`, Instead of assigning to `v->s` firstly.

But in `cmp_ref_sorting()` we will use `get_ref_atom_value()`, It is possible to compare `v->s` of two different refs, I must goto fill object info in `v->s`.

So I think this is one of the reasons why `ref-filter` desires to allocate a large number of strings, right?

-- ZheNing Hu