Re: [PATCH v2 2/2] [RFC] push: allow delete one level ref
- From
ZheNing Hu <adlternative@gmail.com>
- Date
- Feb 25, 2023, 14:11 UTC
- Message-ID
- <CAOLTT8SJGnCb0mkm120XRskyRmRHL_Yix17NyJhDcxMx8HvYiA@mail.gmail.com>
- In-Reply-To
- <xmqq4jrb2dih.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> 于2023年2月25日周六 01:12写道:
Show 24 quoted lines
> > ZheNing Hu <adlternative@gmail.com> writes: > > > ... Therefore, generally speaking, it's better not to let users > > create/update special one-level references. > > The question was "Is it that we are actively discouraging one-level > refs like refs/stash, so removing is fine but once removed we do not > allow creating or updating?" > > You could just have given a single word answer, Yes, then. > > > Certainly, I can remove the previous section as you requested. > > I didn't request to do anything to the change. I asked you to > explain why you allow only delete without create/update, and without > knowing why, I didn't have enough information to make such a request. > > I think "we discourage a single-level refnames so allow deleting one > that may have been created by mistake, but do not allow creation or > deletion as before" does make sense. As long as that is explained > in the proposed log message and in the end-user facing documentation, > I am happy with the new behaviour. >
I understand. I didn't mention the reason for not allowing the creation/update of one-level refs in the commit message, I will add it later.
> Thanks.