Re: [PATCH 0/4] [GSOC][RFC] ref-filter: add %(rest) atom
- From
ZheNing Hu <adlternative@gmail.com>
- Date
- Jun 9, 2021, 03:55 UTC
- Message-ID
- <CAOLTT8RURwom91VqFATjMEGGe5NJRgyWSojCC=TH8DwG+7MeSA@mail.gmail.com>
- In-Reply-To
- <xmqqtum7ln9m.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> 于2021年6月9日周三 上午11:39写道:
Show 25 quoted lines
> > "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > In order to let git cat-file --batch reuse ref-filter logic, in this > > version, the atom %(rest) is added to ref-filter. > > > > Change from last version: > > > > 1. Deleted two commit about %(raw:textconv) and %(raw:filters), their > > construction will be after letting cat-file --batch uses ref-filter > > logic. > > 2. Exchange the order of the definition of "cmp_fn" and the declaration of > > "a_size" and "b_size" in cmp_ref_sorting(), to avoid breaking > > -Wdecl-after-stmt. > > 3. Delete --rest option, "git for-each-ref" family will reject %(rest) by > > default. > > 4. Add GPG prefix to some %(raw) tests. > > > > ZheNing Hu (4): > > [GSOC] ref-filter: add obj-type check in grab contents > > [GSOC] ref-filter: add %(raw) atom > > [GSOC] ref-filter: use non-const ref_format in *_atom_parser() > > [GSOC] ref-filter: add %(rest) atom > > Thanks, will replace.
It’s worth mentioning that this patch still fails the github CI test. [1]
t6300-for-each-ref.sh: 274: Verify sorts with raw 275: Verify sorts with raw:size 278: empty raw refs with %(if)
There is no such breakage on my local machine.
[1] https://github.com/gitgitgadget/git/pull/976/checks?check_run_id=2774963705