Re: [PATCH v6] [GSOC] ref-filter: fix read invalid union member bug

From: ZheNing Hu <adlternative@gmail.com>
Date: May 13, 2021, 09:29 UTC
Message-ID: <CAOLTT8R0sXRLB5=ePGi9dSpKR+YFSYLtDPvoD8PhNzneF0=NrQ@mail.gmail.com>
In-Reply-To: <xmqqfsyredsr.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> 于2021年5月13日周四 上午7:24写道：

Show 9 quoted lines

>
> "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > +test_expect_success '%(color:#aa22ac) must succeed' '
> > +     mkdir test &&
>
> You do not need "mkdir test" here, as "git init test" would take
> care of it.
>

Make sence.

Show 7 quoted lines

> On the other hand, you'd want to get 'test' directory removed after
> this passes, so
>
>         test_when_finished rm -fr test &&
>
> would be useful.
>

Well, deleting or not deleting the directory "test" is not a big problem here. Delete it is ok.

> Other than that, looks good to me.
>
> Thanks.
>

Thanks. -- ZheNing Hu