Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]

From: ZheNing Hu <adlternative@gmail.com>
Date: Oct 31, 2022, 14:26 UTC
Message-ID: <CAOLTT8QygkMyjFqxsOo8fqh3yWE3najwv+Y8ekr8MP9d_+dotg@mail.gmail.com>
In-Reply-To: <CA+CkUQ_pqQomaA=MO78PsC0oA8GcE0dJ415fpjcLx6k5HNaDiw@mail.gmail.com>

Hi, Hariom and NSENGIYUMVA,

Hariom verma <hariom18599@gmail.com> 于2022年10月28日周五 16:08写道：

Show 15 quoted lines

>
> Hi,
>
> > Olga<olyatelezhnaya@gmail.com> has done great work in “Unifying Git’s
> > format languages” during Outreachy Round 15 and continued even after
> > that [from 28-09-2017 to 04-04-2019]. Her work is mostly related to
> > `cat-file` and `ref-filter`.
> >
> > She already did a pretty nice job in preparing ref-filter for more
> > general usage of its formatting logic. It will give me the possibility
> > to make the migration of pretty.c easier.
>
> ZheNing Hu continued the Olga's work during GSoC'21. You can tell a
> bit more about that too.
>

I'm afraid I'm skeptical about the progress of this project. Yes, this project has been going on for too long, probably 3 years, and it is long overdue to be merged into master. Maybe we all need to rethink the nature of this project instead of rushing to start writing code.

As far as I know, these unified format refactor are easy to implement, but as we use more complex parsing logic, there will be a lot of performance degradation.

I recommend new contributors to perform performance analysis and performance optimization directly based on the original developer's patches.

Show 10 quoted lines

> --
>
> I would review the rest later.
>
> It seems like you used my proposal as a template. Just want to let you
> know, you are not restricted to using any particular template. Feel
> free to add or remove any section you find relevant.
>
> Thanks,
> Hariom

I will pay close attention to this issue.

Thanks, -- ZheNing Hu