Re: [PATCH v2 2/2] [GSOC] ref-filter: add %(raw) atom
- From
ZheNing Hu <adlternative@gmail.com>
- Date
- May 31, 2021, 14:40 UTC
- Message-ID
- <CAOLTT8QFW4UrwZ+OboYqkoT-oKo1Sz3JJ-Fp8b2RWugMOy5Cug@mail.gmail.com>
- In-Reply-To
- <xmqqtumjy2e4.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> 于2021年5月31日周一 下午12:04写道:
Show 19 quoted lines
>
> "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > @@ -530,6 +545,7 @@ static struct {
> > { "body", SOURCE_OBJ, FIELD_STR, body_atom_parser },
> > { "trailers", SOURCE_OBJ, FIELD_STR, trailers_atom_parser },
> > { "contents", SOURCE_OBJ, FIELD_STR, contents_atom_parser },
> > + { "raw", SOURCE_OBJ, FIELD_STR, raw_atom_parser },
> > { "upstream", SOURCE_NONE, FIELD_STR, remote_ref_atom_parser },
> > { "push", SOURCE_NONE, FIELD_STR, remote_ref_atom_parser },
> > { "symref", SOURCE_NONE, FIELD_STR, refname_atom_parser },
>
> Doesn't this conflict with your own zh/ref-filter-atom-type topic?
> Shouldn't one build on top of the other?
>
> Or did we find something fundamentally broken about the other topic
> to make us retract it that I do not remember?
>
> Thanks.I am waiting for zh/ref-filter-atom-type to be merged into master. But it hasn't happened yet. But if I want to base the current topic on zh/ref-filter-atom-type, GGG will send past patches (zh/ref-filter-atom-type) repeatedly. If necessary, I will submit the current branch based on zh/ref-filter-atom-type.
Thanks. -- ZheNing Hu